Repository navigation
ci(.github/workflows): stop doc-check workspaces after each review - #29851
Merged
nickvigilante merged 1 commit intoSep 24, 2026
Conversation
bpmct
approved these changes
Sep 24, 2026
nickvigilante
marked this pull request as ready for review
September 24, 2026 15:02
nickvigilante
changed the base branch from
vigilante/dog-55-pre-push-hook-never-runs-go-tests-and-segfaults-make-in-some
to
main
September 24, 2026 15:03
Each PR's doc-check-pr-<N> workspace kept running until autostop, and nothing deleted it afterward. On docfood.cdr.dev, 54 of them ran at once and drove the host's load average to about 2900. Stop the workspace once the chat reaches a terminal status, start it again before the next review, and delete it when the PR merges. PRs closed without merging keep their workspace, because stale PRs get closed and reopened and the review context has to survive. Runs for the same PR now share a concurrency group, so one run cannot stop or delete the workspace while another run is reviewing in it. Refs DOCS-1007, CODAGT-1025.
nickvigilante
force-pushed
the
vigilante/docs-1007-doc-check-stop-review-workspace-after-each-run-and-delete-it
branch
from
September 24, 2026 15:57
d95e332 to
49a5f06
Compare
nickvigilante
enabled auto-merge (squash)
September 24, 2026 15:58
nickvigilante
deleted the
vigilante/docs-1007-doc-check-stop-review-workspace-after-each-run-and-delete-it
branch
September 24, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc-check creates one
doc-check-pr-<N>workspace per PR and never stops or deletes it. On docfood.cdr.dev, 54 of them ran at once, and the host's load average reached about 2900, mostly from processes blocked on I/O.This stops the review workspace once the chat reaches a terminal status, starts it again before the next review, and deletes it when the PR merges. A PR closed without merging keeps its workspace, because stale PRs get closed and reopened and the review needs its context back. Runs for the same PR share a concurrency group, so one run cannot stop or delete the workspace while another is reviewing in it.
The workspace lookup also now matches the name exactly. The
name:filter matches substrings (coderd/database/queries/workspaces.sql), sodoc-check-pr-12also matcheddoc-check-pr-123.Depends on #29849, which fixes the pre-push hook crash that blocked pushing this branch. Retarget to
mainafter it merges.Refs DOCS-1007, CODAGT-1025
Decision log
Choices
waiting,completed,error). When the 40-minute wait times out, the chat is still working in the workspace, so the step leaves it running.start_workspace. The job timeout goes from 45 to 50 minutes to make room. A failed start only warns, so the agent's existing recovery path still applies.closedwithoutmergedkeeps the workspace. Workspaces for PRs that close and never reopen will pile up (stopped, then dormant) until a sweep removes them.cancel-in-progress: false. Canceling a job does not cancel the Coder chat, so cancellation would not stop the review it interrupts.Follow-up
Replace per-PR workspaces with one persistent doc-check workspace and a git worktree per PR, pinned through the action's
workspace-idinput.Verification
actionlintandzizmor --persona=regularpass.workspacesfield.🤖 Generated by Coder Agents on behalf of @nickvigilante.