fix: make OAuth2 code redemption single-use under concurrency - #28744
Draft
BobbyHo wants to merge 1 commit into
Draft
fix: make OAuth2 code redemption single-use under concurrency#28744BobbyHo wants to merge 1 commit into
BobbyHo wants to merge 1 commit into
Conversation
Two concurrent redemptions of one authorization code both minted a token. The redeeming delete was a blind :exec with no affected-rows check, so the request that lost the race deleted nothing and carried on as if it had won. DeleteOAuth2ProviderAppCodeByIDReturningRow returns the row it removed, so a delete that removed nothing surfaces sql.ErrNoRows. The token exchange maps that to the invalid_grant it already returns for an unknown code, which makes the delete the arbiter of single use (RFC 6749 §10.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Third of the PLAT-480 stack, stacked on #28740. An authorization code could be redeemed twice under concurrency; this makes the redeeming delete the arbiter of single use.
RFC 6749 §10.5 requires an authorization code to be single-use. The redeeming delete was a blind
:execwith no affected-rows check, so two concurrent redemptions of one code both minted a token.sql.ErrNoRowsand is refused withinvalid_grant, the same response an unknown code already gets.Depends on #28740
Stack: #28237, #28740, this PR.