fix(site): render change-version picker in place so it clears the dialog - #28490
Merged
matifali merged 3 commits intoAug 25, 2026
Merged
Conversation
…alog On release/2.36 the Change version dialog is still an MUI Dialog (z-index: 1300), while the version picker is a Radix popover that portals to document.body at z-50. Two body-level portals means the options paint behind the dialog surface and are unclickable (DEVEX-780). Bump the ComboboxContent z-index above the MUI dialog so the portalled popover renders in front. main is unaffected: #27506 already moved all dialogs onto Radix, but that landed after the 2.36 branch cut.
On release/2.36 the Change version dialog is still an MUI Dialog (z-index: 1300), while the version picker is a Radix popover that portals to document.body at z-50, so the options paint behind the dialog surface and are unclickable (DEVEX-780). Render the popover in place with disablePortal instead. It stays inside the dialog's stacking context (so it paints in front without a magic z-index) and inside the focus trap, which is the accessibility issue the ticket describes. main is unaffected: #27506 already moved all dialogs onto Radix, but that landed after the 2.36 branch cut.
jakehwll
marked this pull request as ready for review
August 24, 2026 16:55
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98aba67b36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
matifali
approved these changes
Aug 24, 2026
jeremyruppel
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the DEVEX-780 fix to
release/2.36.mainis already fine, this is for shipped 2.36.x.Problem
In the Change version dialog, the version picker options are unclickable, painted behind the dialog surface.
The picker uses the shared Radix
Popover, which portals todocument.bodyatz-50(see #23374). Onrelease/2.36the dialog is still an@mui/material/Dialogatz-index: 1300. Two body-level portals,50loses to1300, so the options render behind the dialog.mainis unaffected because #27506 moved every dialog onto Radix, but that landed after the 2.36 branch cut, so 2.36.x shipped broken.Fix
Set
disablePortalon the dialog'sComboboxContentso the popover renders in place instead of portalling todocument.body. It stays inside the dialog's stacking context and focus trap, so it paints in front and stays accessible without a z-index magic number chained to MUI's internal1300.Backporting #27506 wholesale is not viable, it touches ~30 dialogs. This is the smallest scoped change.