fix(site/src/pages): use RotateCcwIcon for update actions - #28183
Open
designertyler wants to merge 1 commit into
Open
fix(site/src/pages): use RotateCcwIcon for update actions#28183designertyler wants to merge 1 commit into
designertyler wants to merge 1 commit into
Conversation
The update actions used a cloud icon, which reads as a cloud/network concept rather than update and restart. RotateCcwIcon is already used for the Restart button and for the Update action in WorkspaceOutdatedTooltip and AgentOutdatedTooltip, so reuse it for the workspace page update button, the workspaces table primary actions, and the batch update menu item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DES-22067.
The "Update and restart" / "Update and start" actions used
CloudIcon, which reads as a cloud/network concept instead of an update-and-restart build action.Switch them to
RotateCcwIcon, which the UI already uses for:Restartbutton on the workspace pageUpdateaction inWorkspaceOutdatedTooltip,AgentOutdatedTooltip, andSubAgentOutdatedTooltipCall sites changed:
WorkspacePage/WorkspaceActions/Buttons.tsx-UpdateButtonWorkspacesPage/WorkspacesTable.tsx- "Update and start workspace" and "Update and restart workspace" primary actionsWorkspacesPage/WorkspacesPageView.tsx- batch "Update" menu itemThe
requireActiveVersionvariant still usesPlayIcon, since that path starts the workspace on the active version rather than offering a choice. Worth a separate design pass if that should change too.Investigation notes
Verified against
origin/main(af90d8e2be): no prior PR referenced DES-22067 and all threeCloudIconusages were still present.grepconfirms noCloudIconusages remain insite/srcafter this change.Icon conventions found in the codebase:
RotateCcwIcon: restart, update (outdated tooltips), retry (RetryButton, TasksTable, TaskPage, HealthLayout)RefreshCwIcon/RefreshCcwIcon: softer "reload data" flows (terminal, secrets, prebuilds invalidate, inbox, git panel)data-testid="bulk-action-update"is preserved on the batch update item, so e2e coverage is unaffected.Generated by Coder Agents on behalf of @designertyler.