Skip to content

docs: fix Helm TLS/ingress value keys in admin/setup (#28087) - #28162

Merged
nickvigilante merged 1 commit into
release/2.29from
backport/28087-to-2.29
Aug 14, 2026
Merged

docs: fix Helm TLS/ingress value keys in admin/setup (#28087)#28162
nickvigilante merged 1 commit into
release/2.29from
backport/28087-to-2.29

Conversation

@github-actions

Copy link
Copy Markdown

Backport of #28087

Original PR: #28087 — docs: fix Helm TLS/ingress value keys in admin/setup
Merge commit: 5b97d99
Requested by: @nickvigilante

## What

Fix the Helm values in the TLS setup step of
`docs/admin/setup/index.md`. The documented keys are silently ignored by
the chart, so TLS appears configured but isn't.

## Changes

- `coder.tls.secretName` (singular) → `coder.tls.secretNames` (a list).
The chart key is `secretNames`.
- `coder.ingress.secretName` / `coder.ingress.wildcardSecretName` →
nested under `coder.ingress.tls.secretName` /
`coder.ingress.tls.wildcardSecretName`, where the chart actually reads
them.
- Added `coder.ingress.tls.enable: true` so the ingress-termination
example actually enables TLS.

All keys verified against `helm/coder/values.yaml` on `main`
(`coder.tls.secretNames`,
`coder.ingress.tls.{enable,secretName,wildcardSecretName}`). Surfaced by
the runtime drift sweep. The example now parses to the correct chart
structure.

Linear:
[DOCS-643](https://linear.app/codercom/issue/DOCS-643/docs-fix-helm-tlsingress-value-keys-in-adminsetup-secretnames)

> This PR was created with AI assistance (Coder Agents).

(cherry picked from commit 5b97d99)
@github-actions github-actions Bot added the backport/v2.29 Backport PR targeting release/2.29 label Aug 14, 2026
@github-actions
github-actions Bot requested a review from nickvigilante August 14, 2026 16:50
@nickvigilante
nickvigilante enabled auto-merge (squash) August 14, 2026 16:53
@nickvigilante
nickvigilante merged commit c85a3d2 into release/2.29 Aug 14, 2026
@nickvigilante
nickvigilante deleted the backport/28087-to-2.29 branch August 14, 2026 16:53
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/v2.29 Backport PR targeting release/2.29

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant