feat(cli): add progress reporting to notifications scaletest - #28096
Open
cstyan wants to merge 1 commit into
Open
feat(cli): add progress reporting to notifications scaletest#28096cstyan wants to merge 1 commit into
cstyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the third in a stack that supersedes #27717.
In this PR we add progress logging so operators can see what the load generator pod is doing while setup and cleanup run. At scale these phases take minutes, and without output an operator can mistake a slow-but-healthy run for a hang and kill the process, which is the one exit the deferred cleanup can't cover. When the --reuse-user flag is used this can potentially leave behind promoted users and live tokens behind, see the previous PR.
The change adds a progress tracker that, on a 15s interval, writes a line to stderr showing completed/total and elapsed time for the current phase (creating, preparing, deleting, or restoring users).