fix(site/src): replace hardcoded text-[13px] with scale tokens outside agents - #28071
Open
tracyjohnsonux wants to merge 7 commits into
Open
fix(site/src): replace hardcoded text-[13px] with scale tokens outside agents#28071tracyjohnsonux wants to merge 7 commits into
tracyjohnsonux wants to merge 7 commits into
Conversation
…riant instead of class override
…s for popover body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the arbitrary
text-[13px]value with the design-system tokenstext-sm(14px) ortext-xs(12px) in the 18 non-agents files that used it.AgentsPageusages andmodules/resources/AgentMetadata.tsxare intentionally left alone; they'll be handled with the agents UI separately.Because the custom Tailwind scale bakes
font-weight: 500intotext-xs/text-sm,font-normalwas added wherever the text previously rendered at 400 and is prose, code, or log content, so only the size changes there. Short labels, headers, and numeric values take the token's 500 weight as-is.Token decisions
components/Logs/LogLine.tsxtext-xs font-normalcomponents/PaginationWidget/PaginationAmount.tsxtext-xs font-normalpages/IconsPage/IconsPage.tsx(figcaption)text-xs font-normalpages/WorkspacesPage/WorkspacesButton.tsxtext-xs font-normalmodules/templates/TemplateExampleCard.tsx,pages/CreateTemplateGalleryPage/...text-xs font-normalcomponents/FullPageLayout/Sidebar.tsx/Topbar.tsxtext-sm(Topbar addsfont-normal)font-normalavoids leaking 500 into all childrencomponents/Paywall/PaywallPremium.tsxtext-sm font-normalmodules/templates/TemplateFiles/TemplateFiles.tsx/TemplateFileTree.tsxtext-smfont-medium)modules/workspaces/WorkspaceOutdatedTooltip.tsxtext-sm font-normalpages/WorkspacePage/ResourcesSidebar.tsxtext-sm font-normalpages/AISettingsPage/.../CredentialField.tsxtext-sm font-normalpages/DeploymentSettingsPage/Option.tsxtext-smfont-semiboldpages/HealthPage/Content.tsxtext-sm font-normalpages/TemplateVersionEditorPage/TemplateVersionEditor.tsxtext-smpages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsxtext-sm(font-normalon prose/empty state)Storybook review checklist
Stories directly covering changed components:
Logs/LogLineandLogs/LogsPaywall/PaywallPremiumTemplateExampleCardTemplateFilesandTemplateFileTreeWorkspaceOutdatedTooltipCreateTemplateGalleryPageViewIconsPageTemplateInsightsPageTemplateVersionEditor(also exercises FullPageLayoutTopbar/Sidebar)Indirect coverage for components without their own stories:
PaginationAmount→PaginationWidget/PaginationContainerstories, plus paginated page views (UsersPageView,AuditPageView,ConnectionLogPageView)WorkspacesButton→WorkspacesPageViewstories (open the "New workspace" combobox)HealthPage/Content→HealthPage/*Pagestories (DERPPage,DatabasePage, etc.)ResourcesSidebar→WorkspacePage/Workspacestories (failed-build state)FullPageLayout Topbar/Sidebar→TemplateVersionEditorstoriesCredentialField→ProviderForm/AddProviderPageViewstoriesNo story exists for
DeploymentSettingsPage/Option; verify on the deployment settings page (option value pills).🤖 This PR was generated by Coder Agents on behalf of @tracyjohnsonux.