-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: render chat summaries as a headline plus bullets #28013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jaaydenh
wants to merge
7
commits into
main
Choose a base branch
from
chat-summary-7v0c
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ede189b
feat: render chat summaries as a headline plus bullets
jaaydenh 634f890
fix(site/src/pages/AgentsPage/components): address summary panel review
jaaydenh dff5f06
docs(coderd/x/chatd): correct stale chat summary format comments
jaaydenh 9af0084
fix(site/src/pages/AgentsPage/components): wrap long identifiers in s…
jaaydenh 90f83d6
test(site/src/pages/AgentsPage/components): drop geometry assertion f…
jaaydenh 32cd37b
perf(site/src/pages/AgentsPage/components): settle summary resize mea…
jaaydenh 1b6328d
fix(site/src/pages/AgentsPage/components): reset summary expansion pe…
jaaydenh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This return now serializes a headline followed by Markdown bullets, but
generateChatSummaryis still documented immediately above as generating a "1-3 sentence whole-chat summary." That stale contract can mislead future callers and tests about the persisted format; update the function comment to describe the headline-plus-bullets output.AGENTS.md reference: AGENTS.md:L180-L183
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in dff5f06. Correct, that comment was stale.
The same change had also invalidated a second comment you did not flag:
coderd/x/chatd/chatd.go:4729bounded the extracted subagent report snippet "near the 1-3 sentence generated summaries that root chats get". The snippet caps themselves are unchanged at 300 runes / 3 sentences, which now corresponds to the headline rather than a whole summary, so I updated that wording too.Swept for other references to the old contract and found none;
ARCHITECTURE.mddocuments no summary format contract, so it needed no change.