refactor(site): add <Drawer /> and migrate build logs drawer - #28009
Open
jakehwll wants to merge 8 commits into
Open
refactor(site): add <Drawer /> and migrate build logs drawer#28009jakehwll wants to merge 8 commits into
<Drawer /> and migrate build logs drawer#28009jakehwll wants to merge 8 commits into
Conversation
jakehwll
marked this pull request as ready for review
August 11, 2026 02:55
<Drawer /> and migrate build logs drawer
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df4a2fb409
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…n build logs drawer closes
…ling to parent via onCloseAutoFocus
Member
this seems like it's lacking definition between foreground and background |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #27798. That PR introduced a shared
Drawerprimitive by addingvaulas a dependency. As raised in review,vaulis currently unmaintained, and this drawer is the only place in the UI using that concept.This PR takes the suggested route: a dead-simple, self-owned drawer that covers this one case well, built directly on Radix UI's
Dialog(already a dependency viaradix-ui) instead ofvaul. It keeps the same shadcn-style API (Drawer,DrawerTrigger,DrawerContent,DrawerHeader,DrawerFooter,DrawerTitle,DrawerDescription,DrawerClose) so usage stays familiar, and migratesCreateTemplatePage'sBuildLogsDraweroff MUI onto it.What changed
site/src/components/Drawer/Drawer.tsx: a reusable drawer/sheet built onradix-uiDialog. Supports adirectionprop (top/bottom/left/right, defaultright) with slide animations viatailwindcss-animate. No new dependencies.BuildLogsDrawerfrom@mui/material/Drawerto the new component. Desktop panel stays at 800px viamin(800px, 100%)so it stays within the viewport on mobile.play()functions for both the genericDrawer(open/close, direction) andBuildLogsDrawer(close via the X button and via Escape assertonClose), addressing the earlier P1 review note about covering the controlled close path.Why Radix instead of vaul
radix-uiDialogis already a dependency and provides accessibility, focus management, and open/close state.vaul's drag-to-dismiss gesture is not needed for this build-logs use case.