fix(site/src/pages/GroupsPage): show no budget instead of unlimited for empty AI budget - #27993
fix(site/src/pages/GroupsPage): show no budget instead of unlimited for empty AI budget#27993tracyjohnsonux wants to merge 6 commits into
Conversation
…or empty AI budget
Documentation CheckUpdates Needed
Automated review via Coder Agents |
|
| rel="noreferrer" | ||
| size="sm" | ||
| > | ||
| View docs |
There was a problem hiding this comment.
I would suggest something like: How effective group is resolved.
There was a problem hiding this comment.
Good call. Updated in c3a9cb4 to "Learn how effective budget is resolved" per Tracy's wording.
Reply posted by Coder Agents on behalf of @tracyjohnsonux.
There was a problem hiding this comment.
Slight update to be a bit less jargon-y
Learn how budgets apply across groups
| // Both an empty value and $0 leave the group without a budget. An explicit | ||
| // $0 limit additionally calls out that it disables AI access. |
There was a problem hiding this comment.
This is not entirely correct, a $0 blocks a user. I would suggest just replacing the unlimited
| // Both an empty value and $0 leave the group without a budget. An explicit | |
| // $0 limit additionally calls out that it disables AI access. | |
| // Empty means no budget; $0 disables AI access. Both states show an | |
| // explanatory alert alongside the summary line. |
There was a problem hiding this comment.
Applied in 44b814a, with one tweak: the second sentence of the suggestion ("Both states show an explanatory alert") no longer holds since the empty state dropped its alert, so it now reads "Only the $0 state shows an explanatory alert alongside the summary line."
Reply posted by Coder Agents on behalf of @tracyjohnsonux.
…cost-controls doc
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
An empty per-member AI budget on the group settings page previously displayed "unlimited budget" with a "Members in this group have no spending cap." alert. Unlimited spend only applies when the everyone group is the sole group, so this messaging was misleading everywhere else.
Changes
docs()helper.unlimitedtono budget.AIBudgetUncappedstory expectations to match.Unchanged
$0still shows the "A $0 limit disables AI access for this group." alert, as before.nullto the budget API; backend semantics are untouched.Story tests pass:
pnpm test:storybook src/pages/GroupsPage/GroupSettingsPageView.stories.tsx(7/7).This PR was generated by Coder Agents on behalf of @tracyjohnsonux.