chore: sync fantasy fork with upstream v0.40.0 and openai-go with v3.50.0 - #27981
Open
ibetitsmike wants to merge 1 commit into
Open
chore: sync fantasy fork with upstream v0.40.0 and openai-go with v3.50.0#27981ibetitsmike wants to merge 1 commit into
ibetitsmike wants to merge 1 commit into
Conversation
…50.0 Bumps the charm.land/fantasy replace to coder/fantasy coder_2_33 synced with upstream charmbracelet/fantasy v0.40.0 (coder/fantasy#51), and the openai-go/v3 replace to coder/openai-go coder/pinned rebased onto upstream v3.50.0 (coder/openai-go#10). Fork hacks now superseded upstream and dropped from our diff: truncated stream fail-closed detection (Anthropic + OpenAI Responses), Anthropic EffortXHigh, computer use, thinking effort/display, replay fidelity for signed reasoning and web_search errors, PDF/text documents with sanitized filename titles, refusal finish-reason mapping, gpt-5.5/5.6 Responses routing, the Go 1.25 downgrade, and the openai-go SSE decoder and appendCompact patches. Fork hacks still needed and preserved: OpenAI computer use, Responses replay continuity validation, Anthropic pre-4.6 budget-thinking conversion and effort none, RefusalMetadata parsing, Bedrock cross-region profile mirroring, and openai-go deferred body serialization with the WithJSONSet fix. New upstream features picked up along the way include stream transport retry with in-band SSE error classification, Bedrock auth error refresh, per-message cache markers for OpenAI-compatible models, tool panic recovery, and extra usage fields in provider metadata. Adaptations in this repo: - responses.ResponseOutputItemUnion.Arguments became a union in openai-go v3.50; read the JSON string via .OfString. - Register the new fantasy Call.Headers, ObjectCall.Headers, and ToolResultPart.ClientMetadata fields in the chatdebug coverage map. - Make the integration-test RST listener drain the request before resetting so the client error is deterministic; the new SDK's write path exposed the previous race as sporadic "use of closed network connection" failures.
Collaborator
Author
Remote UAT: PASSDogfooded this PR on a fresh dev.coder.com workspace at commit Validated:
No issues found in the PR's risk surface. Full evidence (screenshots, recording, manifest) attached to the UAT chat: https://dev.coder.com/agents/32b33ee2-68f1-41ec-bb18-3142234e363b Not covered at runtime: Bedrock/Azure/Google providers, AI Bridge intercept beyond unit-test coverage, load/concurrency.
|
Collaborator
Author
Remote UAT round 2 (OpenAI focus): PASSSame chat, same commit Validated with real
Findings (neither blocks this PR):
Evidence attached to the UAT chat: https://dev.coder.com/agents/32b33ee2-68f1-41ec-bb18-3142234e363b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our fantasy fork had drifted far behind upstream charmbracelet/fantasy (base v0.31.0 vs current v0.40.0). This PR updates the pinned forks after reconciling which fork hacks upstream has fixed and which we still need, and adapts this repo to the new APIs.
Fork updates
charm.land/fantasy-> coder/fantasy#51:coder_2_33synced with upstream v0.40.0.github.com/openai/openai-go/v3-> coder/openai-go#10:coder/pinnedrebased from v3.16.0 onto upstream v3.50.0 (required by upstream fantasy).coder/anthropic-sdk-gopin unchanged; the fantasy fork now tracks the same revision this repo ships.Hack reconciliation summary
Dropped from our fantasy diff (upstream now has equivalents, often stricter): truncated-stream fail-closed detection, Anthropic EffortXHigh / computer use / thinking effort / thinking display, replay fidelity for signed reasoning and web_search errors, PDF and text documents with sanitized filename titles, refusal finish-reason mapping (upstream also maps Bedrock
content_filtered/guardrail_intervened), gpt-5.5/5.6 Responses routing, the Go 1.25 downgrade, and the openai-go SSE decoder and appendCompact patches.Still fork-only and preserved: OpenAI computer use, OpenAI Responses replay continuity validation, Anthropic pre-4.6 budget-thinking conversion plus explicit thinking disable for effort none, Anthropic RefusalMetadata parsing, Bedrock cross-region inference profile region mirroring, and openai-go deferred body serialization with the WithJSONSet fix.
Picked up new upstream features: stream transport retry with in-band SSE error classification, Bedrock expired-credential refresh, per-message cache markers for OpenAI-compatible models, tool panic recovery, extra usage fields in provider metadata, and ClientMetadata on tool results.
Changes in this repo
aibridge/intercept/responses:ResponseOutputItemUnion.Argumentsbecame a union type in openai-go v3.50; read function-call arguments via.OfString(plus test literal updates).coderd/x/chatd/chatdebug: register the new fantasyCall.Headers,ObjectCall.Headers, andToolResultPart.ClientMetadatafields in the normalization coverage map (all skipped).aibridge/internal/integrationtest: make the RST test listener drain the request before resetting the connection. The new SDK's write path exposed the previous 1-byte-read race as sporadicuse of closed network connectionfailures; the fix holds over 40 consecutive runs.go.mod: rewrite the fork provenance comments to describe the post-sync state.Validation
go build ./...andgo vet ./...clean (vet findings identical to base).-count=1) runs of./coderd/x/chatd/...,./aibridge/...,./coderd/aibridged/...,./coderd/database/db2sdk/: 37 packages pass.TestClientAndConnectionErrorstress-tested 40x clean.