feat(site): generate random hex string (non-uuid) for template builder session ID - #27935
Open
aqandrew wants to merge 5 commits into
Open
feat(site): generate random hex string (non-uuid) for template builder session ID#27935aqandrew wants to merge 5 commits into
aqandrew wants to merge 5 commits into
Conversation
untra
reviewed
Aug 6, 2026
| * Generate a random hexadecimal string from the specified number of bytes. | ||
| */ | ||
| const generateRandomString = (bytes: number): string => { | ||
| const byteArr = crypto.getRandomValues(new Uint8Array(bytes)); |
Contributor
There was a problem hiding this comment.
getRandomValues not getRandomBytes 👍
bytes are mapped into hex characters as a string.
untra
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session ids for template builder telemetry need to be hexadecimal strings, not UUIDs.
generateSessionIdhelper function which reuses our existinggenerateRandomStringlogicgenerateRandomStringfunction to begenerateRandomBase64Stringadditional context from #27671 (comment):