refactor(site): tidy secrets list layout - #27917
Conversation
Tighten the user secrets settings page layout. Move the enable toggle into a leading column, truncate long descriptions, promote Add secret and docs into the settings header actions, and drop the redundant Refresh control now that mutations already invalidate the secrets query.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 412d6f6cac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rel="noreferrer" | ||
| > | ||
| <SquareArrowOutUpRightIcon /> | ||
| Read the docs |
There was a problem hiding this comment.
Update the Storybook play for the renamed docs link
The Loaded story still calls getByRole("link", { name: "View docs" }), so renaming this link to Read the docs makes its play function throw and breaks the page's Storybook test suite. Update the story alongside this user-visible behavior change.
AGENTS.md reference: site/AGENTS.md:L9-L10
Useful? React with 👍 / 👎.
| <span tabIndex={0} className="inline-flex"> | ||
| <Switch | ||
| aria-label={stateLabel} |
There was a problem hiding this comment.
Keep each switch to one descriptive focus target
When a secret can be toggled, both this span and the inner switch are now tabbable, so keyboard users first land on an unnamed, inert wrapper with no tooltip and must press Tab again to reach the control. The switch is also named only Enabled or Disabled, making multiple rows indistinguishable to assistive technology. Keep the focusable wrapper only for the disabled targetless case and retain a secret-specific accessible name.
AGENTS.md reference: site/AGENTS.md:L18-L19
Useful? React with 👍 / 👎.
Tighten the user secrets settings page layout.
Move the enable toggle into a leading column, truncate long descriptions, promote Add secret and docs into the settings header actions, and drop the redundant Refresh control now that mutations already invalidate the secrets query.