Skip to content

refactor(site): modernize create organization page - #27914

Open
jakehwll wants to merge 4 commits into
mainfrom
jakehwll/create-organizations-refactor
Open

refactor(site): modernize create organization page#27914
jakehwll wants to merge 4 commits into
mainfrom
jakehwll/create-organizations-refactor

Conversation

@jakehwll

@jakehwll jakehwll commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

Modernizes the create organization page to match the AI Providers / OAuth2 create-page pattern.

The page is now a thin permission shell; the view owns the create mutation, uses SettingsHeader with a live icon preview, IconPickerField, field descriptions, and a bordered form card in a centered container. Storybook play coverage and e2e selectors are updated for the new submit label. Unentitled deployments still hit PaywallPremium.

Old New
ORGANIZATION_CREATE_ENTITLED_OLD ORGANIZATION_CREATE
ORGANIZATION_CREATE_OLD ORGANIZATION_CREATE_ENTITLED

@jakehwll
jakehwll marked this pull request as ready for review August 6, 2026 10:22
@jakehwll
jakehwll requested a review from jeremyruppel August 6, 2026 10:22
@coder-tasks

coder-tasks Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/admin/users/organizations.md (line ~64) - Step reads "Enter the details and select Save to continue". This PR renames the submit button from Save to Create organization (see CreateOrganizationPageView.tsx and the updated e2e selectors), so this instruction is now inaccurate and should reference Create organization.
  • docs/admin/users/organizations.md (screenshot images/admin/users/organizations/new-organization.png, line ~66) - The New Organization form is redesigned in this PR (new SettingsHeader with live icon preview, IconPickerField, field descriptions, and a bordered form card). The existing screenshot no longer matches the UI and should be refreshed.

Automated review via Coder Agents

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa1084fbe6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +227 to +229
<Link to="/organizations">
<Button variant="outline" type="button">
Cancel

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render the cancel link as the button root

When keyboard or screen-reader users reach the form actions, this renders a focusable <button> inside a focusable <a>, producing invalid nested interactive markup and two tab stops for the same action. Use the same Button asChild pattern as the back link so the router link itself receives the button styling.

AGENTS.md reference: site/AGENTS.md:L18-L19

Useful? React with 👍 / 👎.

@jaaydenh

jaaydenh commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@jakehwll could you include the Figma link in the description?

@jakehwll

jakehwll commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@jakehwll could you include the Figma link in the description?

There is no Figma, im just aligning to the rest of the "Create" pages 🙂

@jaaydenh

jaaydenh commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@jakehwll regarding the back button placement, I think the create workspace page is a better pattern to follow. When there is no left sidebar, I think having the back button use that space is a bit more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants