fix(enterprise/coderd): identify audit rows by content instead of order in diff tests - #27904
Draft
dylanhuff-at-coder wants to merge 2 commits into
Draft
fix(enterprise/coderd): identify audit rows by content instead of order in diff tests#27904dylanhuff-at-coder wants to merge 2 commits into
dylanhuff-at-coder wants to merge 2 commits into
Conversation
…er in diff tests GetAuditLogsOffset orders by time only, and audit timestamps are rounded to microsecond. On Windows CI the clock resolution is coarse enough that the create and update audit rows frequently tie, making the returned order nondeterministic and flaking TestUserSecretAuditDiffRedaction. Select rows by audit action (or by diff content where both rows share an action) instead of by slice position in the four audit diff tests that relied on ordering. Fixes coder/internal#1625
dylanhuff-at-coder
marked this pull request as ready for review
August 5, 2026 22:40
dylanhuff-at-coder
marked this pull request as draft
August 5, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestUserSecretAuditDiffRedactionflakes when create and update audit rows receive equal timestamps andGetAuditLogsOffsetreturns the tied rows in either order.Identify audit rows by action, or by diff content when both actions are writes, instead of relying on slice position. Fixes coder/internal#1625.
Reviewed and updated by Coder Agents on behalf of @dylanhuff-at-coder.