-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(site): tighten base infra step grid and card typography #27797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
32165db
bb80743
b6e08c1
41ea0f3
6930107
8c6c85f
1806391
ee4753f
361be54
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,11 +134,13 @@ export const BaseTemplateParametersStep: FC< | |
| <div className="mt-6"> | ||
| <MemoizedMarkdown | ||
| className={cn( | ||
| "text-sm font-normal", | ||
| "text-xs font-normal", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note [CRF-37]
No change requested. Flagged because it is the same shape as CRF-17 and CRF-18: a size utility here sets three properties, and only one of them was the intent. The pixel baseline will show whether it reads well.
|
||
| "[&_h2]:mt-6 [&_h2]:text-base [&_h2]:font-semibold", | ||
| "[&_h3]:mt-2 [&_h3]:mb-1 [&_h3]:text-sm [&_h3]:font-semibold", | ||
| "[&_p]:mb-3 [&_p]:text-content-secondary", | ||
| "[&_li]:text-content-secondary", | ||
| "[&_a]:font-normal", | ||
| "[&_code]:text-[length:inherit]", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note [CRF-8]
No action needed. Flagged so that if a font size is ever added to Prism code blocks, this selector is where it gets overridden.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3 [CRF-18] Hisoka compiled the config and read the declarations:
The story fixture at Zoro found the same override missing at the other compact-markdown consumer, and measured it:
One change fixes both problems and both call sites: set
|
||
| )} | ||
| > | ||
| {prerequisites} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,7 +135,7 @@ const SelectField: FC<SelectFieldDefinition> = ({ | |
| )} | ||
| </Label> | ||
| {description && ( | ||
| <div id={descriptionId} className="text-sm text-content-secondary"> | ||
| <div id={descriptionId} className="text-xs text-content-secondary"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2 [CRF-14] The description slot this PR resizes in four places already exists as one component,
Re-raise against CRF-1 with new evidence: the fix moved the resize to the right layer and landed it as four duplicates of a block the codebase owns in one place.
|
||
| {description} | ||
| </div> | ||
| )} | ||
|
|
@@ -185,7 +185,7 @@ const RadioField: FC<RadioFieldDefinition> = ({ | |
| )} | ||
| </Label> | ||
| {description && ( | ||
| <div id={descriptionId} className="text-sm text-content-secondary"> | ||
| <div id={descriptionId} className="text-xs text-content-secondary"> | ||
| {description} | ||
| </div> | ||
| )} | ||
|
|
@@ -276,7 +276,7 @@ const SwitchField: FC<SwitchFieldDefinition> = ({ | |
| {description && ( | ||
| <div | ||
| id={descriptionId} | ||
| className="ml-[44px] text-sm font-normal text-content-secondary" | ||
| className="ml-[44px] text-xs font-normal text-content-secondary" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3 [CRF-16] Only
Mafuuu names why this PR is where it becomes visible:
Gon adds that the card descriptions this PR also resized use
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit [CRF-35]
One line of comment above the
|
||
| > | ||
| {description} | ||
| </div> | ||
|
|
@@ -310,7 +310,7 @@ const SwitchGroupField: FC<SwitchGroupFieldDefinition> = ({ | |
| )} | ||
| </Label> | ||
| {description && ( | ||
| <div id={descriptionId} className="text-sm text-content-secondary"> | ||
| <div id={descriptionId} className="text-xs text-content-secondary"> | ||
| {description} | ||
| </div> | ||
| )} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,7 +62,7 @@ export const ModuleCard: React.FC<ModuleCardProps> = ({ | |
| </div> | ||
|
|
||
| <div> | ||
| <h3 id={nameId} className="text-md font-semibold text-content-primary"> | ||
| <h3 id={nameId} className="text-sm font-bold text-content-primary"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3 [CRF-21]
Robin adds the tell:
Re-raise against CRF-2 with new evidence: the fix hand-copied two class strings, which closed the instance and left the mechanism, and there is now a documented third copy at
|
||
| {name} | ||
| {official && ( | ||
| <> | ||
|
|
@@ -71,15 +71,15 @@ export const ModuleCard: React.FC<ModuleCardProps> = ({ | |
| </> | ||
| )} | ||
| </h3> | ||
| <p className="text-sm font-normal text-content-secondary"> | ||
| <p className="text-xs font-normal text-content-secondary"> | ||
| {description} | ||
| </p> | ||
|
|
||
| <div> | ||
| <Link | ||
| href={detailsUrl} | ||
| target="_blank" | ||
| className="text-sm font-normal" | ||
| className="text-xs font-normal" | ||
| > | ||
| View details | ||
| </Link> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ export const TemplateCard: React.FC<TemplateCardProps> = ({ | |
| </div> | ||
|
|
||
| <div> | ||
| <h3 id={nameId} className="text-md font-semibold text-content-primary"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note [CRF-7] The removed
No action needed in this PR. Worth knowing because it changes what this line does: the title was previously unsized and inherited, so
|
||
| <h3 id={nameId} className="text-sm font-bold text-content-primary"> | ||
|
tracyjohnsonux marked this conversation as resolved.
|
||
| {name} | ||
| {official && ( | ||
| <> | ||
|
|
@@ -71,14 +71,14 @@ export const TemplateCard: React.FC<TemplateCardProps> = ({ | |
| )} | ||
| </h3> | ||
| <div> | ||
| <p className="text-sm font-normal text-content-secondary"> | ||
| <p className="text-xs font-normal text-content-secondary"> | ||
|
tracyjohnsonux marked this conversation as resolved.
|
||
| {description} | ||
| </p> | ||
|
|
||
| <Link | ||
| href={detailsUrl} | ||
| target="_blank" | ||
| className="text-sm font-normal" | ||
| className="text-xs font-normal" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3 [CRF-20] Shrinking the link with a raw
The correct call already exists one step away in the same wizard:
|
||
| > | ||
| View details | ||
| </Link> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 [CRF-17] Dropping the markdown root to
text-xsalso shrinks fenced code blocks from 14px to 12px, which the description does not mention. (Kite P3, Mafu-san P3, Razor P3)Kite measured both sides rather than reasoning about them:
This is shipped content, not an edge case. Razor and Kite both traced it to real bases:
The PR description scopes the code change to "Inline
<code>inherits body size", so the fenced-block shrink reads as unintended. If 12px monospace is the intent, say so; otherwise pin it with[&_.prismjs]:text-sm. Note[&_pre]will not work:Markdown.tsx:62-73unwraps theprewhen it contains acode. This is not CRF-8's mechanism, which three reviewers independently re-verified as genuinely inert for fenced blocks.