fix: don't show admin settings dropdown to everyone - #27481

zed's format on save is so flakey 🙃

@aslilac I added the backport label but we only got PR's for 2.29 and 2.36, neither of which need this. I tried manually cherry-picking into 2.35 but it had merge conflicts, Mux helped identify some additional required commits and I created #27815 off the back of it.

Could I please ask you to review that one, plus also create a backport for 2.34. I also tried for 2.34 but there are aibridge related changes which require more work it seems.

@rowansmithau, given the involvement and needed work to backport this fix, given it’s a mere UI issue and does not affect or block any critical flows, I suggest we drop backporting this.

Would leave the finalestimate to @aslilac though.

I disagree, this is a change in behaviour raised by enterprise customers who have upgraded to the 2.34 ESR release and they are seeking the previous behaviour to be restored. We previously did not show the admin settings menu to non admin users, now we do.

If we are unwilling to backport fixes in order to revert changes implemented in an ESR branch then we should not be making functionality changes to an ESR branch.

@rowansmithau

It's not about unwillingness; it's about the effort required and how critical the bug is. ESR is only critical bug fixes and security updates. This can be considered a UI regression that confuses end users but does not block or impact any critical workflows.

I would wait for @aslilac to comment on this, and we would try our best to backport this.

Just trying to clarify what constitutes a critical bug and what does not not.

https://coder.com/docs/install/releases#extended-support-release

Given 2.36.0 is not out yet 2.34 is still a supported branch.

If we opt not to backport fixes to correct an incorrect behaviour introduced in an ESR branch then that will have a negative impact on both customer's trust of the product and in the ESR branch/process itself.

I agree with you 💯 here. And as I said we should asses this and backport