fix(coderd/x/chatd/chatloop): surface reasoning-only content-filter refusals as terminal errors#27476
Draft
ibetitsmike wants to merge 1 commit into
Draft
fix(coderd/x/chatd/chatloop): surface reasoning-only content-filter refusals as terminal errors#27476ibetitsmike wants to merge 1 commit into
ibetitsmike wants to merge 1 commit into
Conversation
…efusals as terminal errors
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Anthropic can end a stream with
stop_reason: "refusal"after reasoning content has already streamed. The content-filter guard inchatloop.GenerateAssistantonly fired when the step content was completely empty, so a reasoning-only refusal bypassed it: the turn finished asstatus=waitingwithlast_error=null, and the user saw the chat silently stop mid-turn with no explanation. This looked like a Coder fault when the provider had rejected the response. Observed twice in dogfood on 2026-07-23 (chatc72f99fc, debug steps showfinish_reason=content-filterwith reasoning-only content).Change
Treat a content-filter finish as terminal whenever the step produced no user-visible output. A new
hasUserVisibleContenthelper counts any non-reasoning part (text, tool call, tool result) as user-visible; reasoning-only or empty steps now return the existingcontentFilterError, which flows through the established pipeline: classifiedChatErrorKindContentFilter(non-retryable, refusal category/detail when provided), persistedchats.last_error, streamed error event, and the "Response blocked" callout in the chat UI.Behavior for steps with visible text or tool calls is unchanged, and the frontend needs no changes.
Testing
ReasoningOnlyContentSurfacesTerminalError(reasoning stream then content-filter finish) beside the existing empty-content and partial-content subtests, which are unchanged.go test ./coderd/x/chatd/...and lint pass.last_error.kind=content_filterand no retry affordance; text-then-refusal still completes normally; empty refusal still errors.