chore: finish minimum-implicit-member experiment removal#27473
Draft
Emyrk wants to merge 1 commit into
Draft
Conversation
- Delete DeviationRejectedWithoutExperiment (asserted the removed gate) and drop stale experiment naming/setup from the surviving subtests. - Add TestMemberWorkspaceElevation asserting the elevation stays off organization-member/organization-service-account and remains available via organization-workspace-access. - Make the frontend default-roles UI unconditional and remove the defaultRolesEnabled plumbing. - make gen (apidoc, typesGenerated, docs).
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the experiment removal on top of #27472:
DeviationRejectedWithoutExperiment(it asserted the removed 403 gate and would fail), renames the surviving subtests, and drops the now-pointlessdv.Experimentssetup.TestMemberWorkspaceElevationas a witness that the workspace-ops elevation stays offorganization-member/organization-service-accountand lives onorganization-workspace-access.experiments.includes("minimum-implicit-member")sites and the wholedefaultRolesEnabledprop plumbing (pages, view, stories) — required once codegen drops the value from theExperimentunion.make gen: apidoc,typesGenerated.ts, feature-stages/schemas docs.Verified:
go build ./...,TestPatchOrganizationsByUser+TestMemberWorkspaceElevationpass,tsc --noEmitclean.Coder Agents on behalf of @Emyrk.