fix(site/src): address frontend review findings from recent merged PRs#27461
Open
ibetitsmike wants to merge 3 commits into
Open
fix(site/src): address frontend review findings from recent merged PRs#27461ibetitsmike wants to merge 3 commits into
ibetitsmike wants to merge 3 commits into
Conversation
ibetitsmike
force-pushed
the
mike/fe-review-findings-cleanup
branch
from
July 23, 2026 19:51
7484229 to
78ca767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes still-on-main findings from a retrospective
frontend-review(FE1-FE10) audit of the last 30 merged PRs.Changes
aria-selectedprop that cmdk overwrites, remove manual highlight classes duplicated byCommandItem'sdata-[selected=true]styling, and move the scroll-into-view logic into auseEffectEventso the layout effect depends only onselectedinstead of an unstable closure.as HTMLElementin ChatMessageInputstoryHelpers.ts(instanceof narrowing),as TypesGen.ChatinAgentChatPage.stories.tsx(annotation), and all threeas Record<string, unknown>inmodelConfigFormLogic.test.ts(typedproviderState()helper).queryClientparam and no-opvi.restoreAllMocksinChatMessageInput.test.tsx; dedupe the workspace-skills fixture intostoryHelpers.tsasMockWorkspaceSkills.ModelSelectorunset-label selection, MCP server "Revocation URL" field submission (feat: revoke MCP server OAuth grants at the provider on disconnect #27300), narrow-viewport no-overflow forWorkspaceTopbar(fix(site): wrap workspace topbar controls on narrow viewports #27313), mobile full-widthSidebar(fix(site): stack settings layouts on mobile #27334), archive-confirmation dialog for aninterruptingchat inAgentsPageLayout(feat: remove unused chat statuses pending, paused, and completed #27064), and the advisor loading-with-override state.Validation
pnpm format,pnpm lint(biome, tsc, circular deps, knip, react-compiler) clean.AgentChatPage > With Message History,CoderAgentsPageView > Each Override Set To Enabled Model).Audit findings and decisions
Audit scope: last 30 merged PRs by @ibetitsmike; 18 touched
site/srcand were reviewed against.claude/skills/frontend-review/SKILL.md+.claude/docs/FRONTEND_PATTERNS.md.Fixed here (still on main):
aria-selectedon cmdkCommandItem(the literal example FE6 documents), FE3 redundant selected classes and dead test scaffolding, FE9 duplicated fixture.as HTMLElement.as TypesGen.Chatstory cast; the spread already satisfied the type.as Record<string, unknown>in tests.Decisions / accepted gaps:
modelConfigFormLogicform-state cannot be precisely typed per provider without restructuring the runtime-schema-driven form shape; casts were removed via a narrowing helper instead.Sidebarcomponent level instead.WorkspaceTopbarnarrow-viewport story are justified inline: horizontal overflow is the behavior under test (FE10 exception noted in the story).mike/claude-code-chat-runtimebranch, not main.