Skip to content

fix(site/src/pages/AgentsPage): align subagent and auth tool spinners with standard right-side status#27450

Draft
DanielleMaywood wants to merge 1 commit into
mainfrom
fix/agentspage-subagent-spinner
Draft

fix(site/src/pages/AgentsPage): align subagent and auth tool spinners with standard right-side status#27450
DanielleMaywood wants to merge 1 commit into
mainfrom
fix/agentspage-subagent-spinner

Conversation

@DanielleMaywood

@DanielleMaywood DanielleMaywood commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Problem

On the AgentsPage, tool calls render a running spinner in different places depending on the tool. Most tools (read_file, execute, etc.) show the spinner in the standard right-side ToolCall.Status slot, but spawn_agent/subagent calls show it as the leading icon on the left (larger, text-content-link), and wait_for_external_auth does the same. This makes the transcript look inconsistent while tools are in flight.

Fix

Aligned both with the shared pattern: a static semantic leading icon, and the running spinner in the standard right-side ToolCall.Status slot.

  • SubagentTool: the leading icon is now static (Bot, or Monitor for computer-use) instead of a spinner that replaced the icon while running. The running spinner now renders in the standard right-side ToolCall.Status slot. The leading Clock (timeout) and CircleX (error) icons are kept, since they have no ToolCall.Status equivalent and the timeout-vs-error distinction is intentional.
  • WaitForExternalAuthTool: the leading slot now always shows the semantic LogInIcon instead of swapping in a status icon. Running uses the standard right-side ToolCall.Status spinner, and failure uses the standard right-side warning triangle rather than a separate colored icon on the left. Timeout and authenticated outcomes are conveyed by the label text, matching how the message already reads.

Updated the SubagentRunning and WaitForExternalAuthRunning stories to assert the standard Tool call running status indicator. The pre-existing MCP Tool Completed story failure is unrelated (also fails on main).


Generated by Coder Agents on behalf of @DanielleMaywood

@DanielleMaywood
DanielleMaywood force-pushed the fix/agentspage-subagent-spinner branch from a01bc3b to 19e998b Compare July 23, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant