chore(scripts/releaser): remove GPG signing key check#27422
Draft
f0ssel wants to merge 1 commit into
Draft
Conversation
Drop the preflight check that warned and prompted when GPG signing was not configured, along with the conditional tag signing it gated. Release tags are now plain annotated tags (git tag -a). - Remove the GPG check and gpgConfigured plumbing from run.go/release.go. - Drop the sign parameter from ReleaseExecutor.CreateTag and its implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the GPG signing key check from the release wizard. The preflight check warned and prompted "Continue without signing?" when GPG signing was not configured, and the same
gpgConfiguredvalue gated whether the release tag was signed. Both are removed; release tags are now plain annotated tags (git tag -a).Changes
gpgConfiguredplumbing fromrun.goandrunReleaseinrelease.go.signparameter fromReleaseExecutor.CreateTagand both implementations (liveExecutorno longer appends-s).Validation
go build ./scripts/releaser/...go test ./scripts/releaser/...go vet+golangci-lint run ./scripts/releaser/...gofmt -lcleanImportant
Stacked on top of #27421 (base branch
remove-releaser-v2). Review/merge that PR first, then retarget this one tomain.Generated by Coder Agents on behalf of @f0ssel.