chore(dogfood): trust mise configs in mux worktrees#27420
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4284c3aa8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Add
/home/coder/.mux/srcto the dogfood misetrusted_config_pathsdefaults so mise configs in Mux-managed worktrees are trusted out of the box.Background
Mux creates a fresh worktree per workspace under
~/.mux/src/<project>/<branch>. For repos that ship amise.toml(like this one), every fresh worktree is an untrusted mise config directory:mise exec(e.g.make linttargets) blocks forever on the interactivemise trustprompt. When output is captured, the prompt is invisible and looks like a deadlock.Config files ... are not trusted.Either way, each new worktree needs a manual
mise trustbefore builds work.Implementation
The trust list is defined in three places that must stay in lockstep: the
/etc/mise/conf.d/00-coder-trust.tomlfallback baked into bothDockerfile.baseimages, and the user-owned~/.config/mise/conf.d/00-coder-trust.tomlseeded by theinstall-depsscript inmain.tf(mise does not mergetrusted_config_pathsacross config layers). All three get the new path.For home volumes that already have the seeded trust file,
install-depsnow backfills the Mux path into the existingtrusted_config_pathsarray (guarded by a grep so it runs once). The backfill only matches the seeded multi-line layout; files reshaped by the user are left untouched.Validation
Verified on a dogfood workspace: with
/home/coder/.mux/srcintrusted_config_paths, a fresh directory under~/.mux/src/coder/containing this repo'smise.tomlreportstrustedfrommise trust --show, and a mise shim invocation under a PTY that previously hung on the trust prompt returns immediately.The trust-file block was extracted from the template (with the heredoc indent stripped, matching the rendered script) and executed against three fixtures: a pre-change seeded file (backfill inserts the path once, idempotent on re-run), a missing file (seeds the new default list), and a user-reshaped single-line file (left unmodified).
Generated with
mux• Model:anthropic:claude-fable-5• Thinking:xhigh• Cost:$6.34