chore(site/src): exclude stories that fail under pixel 0.2#27403
Open
aslilac wants to merge 4 commits into
Open
chore(site/src): exclude stories that fail under pixel 0.2#27403aslilac wants to merge 4 commits into
aslilac wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #27353. The pixel 0.2.1 engine runs story play functions during snapshotting, and 17 stories currently throw in that environment (they pass under the vitest runner, so this is runner-specific behavior). Excluding them from pixel prevents failed commit statuses from showing up on every PR once #27353 merges.
The excluded stories still run in
test-js; they are only skipped for visual snapshots. They can be fixed and re-enabled individually later.Excluded stories and failure reasons (from the pixel run on #27353)
Unable to find role "button" name "Save Edit"expect(element).toBeVisible()expect(element).toBeVisible()expect(element).toHaveFocus()expectfailureexpectfailureUnable to find role="menuitem" name /Back/Unable to find role="option" name "Claude Sonnet 4"Unable to find role="button" /login with github/iUnable to find role="button" /login with github/iUnable to find text "Authenticated"Unable to find role="button" /login with github/iUnable to find role="button" name "Deselect module"expectfailureexpectfailureexpectfailureAssertionError: expected "createTaskFeedback" to be calledFound multiple elements with the text: backend-apiexpectfailureexpectfailureUpdate: stories under
pages/AISettingsPageandpages/UserSettingsPage/SecretsPagekept producing new failures on subsequent runs, so those story files are now excluded wholesale at the meta level instead of per story.🤖 Generated with Coder Agents on behalf of @aslilac