fix: enforce max body size on CSP violation report endpoint#27243
Merged
Conversation
The /api/v2/csp/reports endpoint is unauthenticated and CSRF-exempt, since it's the browser's report-uri target, and decoded request bodies with no size limit. This let an attacker post arbitrarily large JSON bodies to force unbounded heap allocation and OOM the server (Cure53 CDM-02-007). Wrap the request body in http.MaxBytesReader before decoding and return 413 when the limit is exceeded, matching the existing convention used by files.go, aitasks.go, and exp_chats.go. Fixes: coder/security-disclosures#171
Docs preview📖 View docs preview for |
BobbyHo
marked this pull request as ready for review
July 14, 2026 19:03
jdomeracki-coder
self-requested a review
July 14, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/api/v2/csp/reportsendpoint is unauthenticated and CSRF-exempt, since it's the browser'sreport-uritarget, and decoded request bodies with no size limit. This let an attacker post arbitrarily large JSON bodies to force unbounded heap allocation and OOM the server (Cure53 CDM-02-007).Wraps the request body in
http.MaxBytesReaderbefore decoding and returns 413 when the limit is exceeded, matching the existing convention used byfiles.go,aitasks.go, andexp_chats.go.Fixes: https://github.com/coder/security-disclosures/issues/171