Skip to content

fix(site): flush deferred Radix focus-scope timer before jsdom teardown #26983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EhabY wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Draft

fix(site): flush deferred Radix focus-scope timer before jsdom teardown #26983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd8f101
fix(site): flush deferred Radix focus-scope timer before jsdom teardown
EhabY Jul 5, 2026
dd68831
chore(site/test/setup): tighten timer flush comments
EhabY Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion site/test/setup/msw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,14 @@ afterEach(() => {
server.resetHandlers();
vi.clearAllMocks();
});
afterAll(() => server.close());
afterAll(async () => {
// A leftover fake clock would make the timer flush below hang.
if (vi.isFakeTimers()) {
vi.useRealTimers();
}
// Radix FocusScope defers its unmount dispatch with setTimeout(0). Flush
// it before vitest tears down the jsdom environment, where it would throw
// an unhandled "parameter 1 is not of type 'Event'" TypeError.
await new Promise((resolve) => setTimeout(resolve, 0));
server.close();
});
Loading