fix(site/src/pages/OrganizationSettingsPage): enable sticky positioning for horizontal form sections#26949
Open
aqandrew wants to merge 1 commit into
Open
Conversation
…er>HorizontalSection for organization settings page
jakehwll
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #26907, which re-enabled sticky positioning within
#main-contentthroughout the site. From #26907 (comment):before
Note that I inflated this section's height to 1000px in DevTools to be able to demo sticky positioning not working. This page isn't tall enough at the moment for the lack of sticky positioning to be much of a problem. But this will future-proof it (since
FormSection, whose sticky styles were fixed in #26907, was built for this purpose) and allow us to remove some redundant components/files. No other files importedHorizontalContainerorHorizontalSection, so OrganizationSettingsPage/Horizontal.tsx can be safely deleted.Also note that the Info section is sticky as expected, since it was already using
FormSection. The Workspace Sharing and Delete Organization sections are the ones whose stickiness is fixed by this PRScreen.Recording.2026-07-01.at.3.57.32.PM.mov
after
Screen.Recording.2026-07-01.at.3.58.12.PM.mov