-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: notify users when chats are shared #26914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DanielleMaywood
merged 13 commits into
main
from
danielle/codagt-563-add-notifications-when-a-chat-is-shared
Jul 6, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9921c23
feat(coderd): notify users when chats are shared
DanielleMaywood dc8b4d8
refactor(coderd): consolidate chat-shared notifier escalation
DanielleMaywood d76d39e
fix(coderd): background chat-shared notification fan-out
DanielleMaywood e62d6a0
fix(coderd): only notify direct user-ACL grants on chat share
DanielleMaywood c9a18ef
docs(coderd): drop redundant directChatReaders comment
DanielleMaywood 7381213
fix(coderd/database/migrations): renumber chat shared migration to 00…
DanielleMaywood 93b562c
docs(coderd): drop redundant chat share comments
DanielleMaywood e453b6c
docs(coderd): note server context use in chat share fan-out
DanielleMaywood 9f8c364
refactor(coderd): simplify chat shared notification fan-out
DanielleMaywood 3dff70d
docs(docs/ai-coder/agents): note chat shared notification for direct …
DanielleMaywood 298afd7
docs(coderd): sharpen chat share notification comment, log, and docs
DanielleMaywood 1952856
refactor(coderd): use slice helpers for chat share reader diff
DanielleMaywood 891fb8c
refactor(coderd): drop ctx threading in chat share fan-out
DanielleMaywood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
coderd/database/migrations/000538_chat_shared_notification.down.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| DELETE FROM notification_templates WHERE id = 'b789bd75-d7c6-4cab-9757-1147ab184903'; |
27 changes: 27 additions & 0 deletions
27
coderd/database/migrations/000538_chat_shared_notification.up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| INSERT INTO notification_templates ( | ||
| id, | ||
| name, | ||
| title_template, | ||
| body_template, | ||
| actions, | ||
| "group", | ||
| method, | ||
| kind, | ||
| enabled_by_default | ||
| ) | ||
| VALUES ( | ||
| 'b789bd75-d7c6-4cab-9757-1147ab184903', | ||
| 'Chat Shared', | ||
| E'{{.Labels.initiator}} shared a chat with you', | ||
| E'{{.Labels.initiator}} shared the chat "**{{.Labels.chat_title}}**" with you.', | ||
| '[ | ||
| { | ||
| "label": "View chat", | ||
| "url": "{{base_url}}/agents/{{.Labels.chat_id}}" | ||
| } | ||
| ]'::jsonb, | ||
| 'Chat Events', | ||
| NULL, | ||
| 'system'::notification_template_kind, | ||
| true | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
coderd/notifications/testdata/rendered-templates/smtp/TemplateChatShared.html.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| From: system@coder.com | ||
| To: bobby@coder.com | ||
| Subject: alice shared a chat with you | ||
| Message-Id: 02ee4935-73be-4fa1-a290-ff9999026b13@blush-whale-48 | ||
| Date: Fri, 11 Oct 2024 09:03:06 +0000 | ||
| Content-Type: multipart/alternative; boundary=bbe61b741255b6098bb6b3c1f41b885773df633cb18d2a3002b68e4bc9c4 | ||
| MIME-Version: 1.0 | ||
|
|
||
| --bbe61b741255b6098bb6b3c1f41b885773df633cb18d2a3002b68e4bc9c4 | ||
| Content-Transfer-Encoding: quoted-printable | ||
| Content-Type: text/plain; charset=UTF-8 | ||
|
|
||
| Hi Bobby, | ||
|
|
||
| alice shared the chat "Onboarding kickoff" with you. | ||
|
|
||
|
|
||
| View chat: http://test.com/agents/00000000-0000-0000-0000-000000000001 | ||
|
|
||
| --bbe61b741255b6098bb6b3c1f41b885773df633cb18d2a3002b68e4bc9c4 | ||
| Content-Transfer-Encoding: quoted-printable | ||
| Content-Type: text/html; charset=UTF-8 | ||
|
|
||
| <!doctype html> | ||
| <html lang=3D"en"> | ||
| <head> | ||
| <meta charset=3D"UTF-8" /> | ||
| <meta name=3D"viewport" content=3D"width=3Ddevice-width, initial-scale= | ||
| =3D1.0" /> | ||
| <title>alice shared a chat with you</title> | ||
| </head> | ||
| <body style=3D"margin: 0; padding: 0; font-family: -apple-system, system-= | ||
| ui, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarel= | ||
| l', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif; color: #020617= | ||
| ; background: #f8fafc;"> | ||
| <div style=3D"max-width: 600px; margin: 20px auto; padding: 60px; borde= | ||
| r: 1px solid #e2e8f0; border-radius: 8px; background-color: #fff; text-alig= | ||
| n: left; font-size: 14px; line-height: 1.5;"> | ||
| <div style=3D"text-align: center;"> | ||
| <img src=3D"https://coder.com/coder-logo-horizontal.png" alt=3D"Cod= | ||
| er Logo" style=3D"height: 40px;" /> | ||
| </div> | ||
| <h1 style=3D"text-align: center; font-size: 24px; font-weight: 400; m= | ||
| argin: 8px 0 32px; line-height: 1.5;"> | ||
| alice shared a chat with you | ||
| </h1> | ||
| <div style=3D"line-height: 1.5;"> | ||
| <p>Hi Bobby,</p> | ||
| <p>alice shared the chat “<strong>Onboarding kickoff</strong>= | ||
| ” with you.</p> | ||
| </div> | ||
| <div style=3D"text-align: center; margin-top: 32px;"> | ||
| =20 | ||
| <a href=3D"http://test.com/agents/00000000-0000-0000-0000-000000000= | ||
| 001" style=3D"display: inline-block; padding: 13px 24px; background-color: = | ||
| #020617; color: #f8fafc; text-decoration: none; border-radius: 8px; margin:= | ||
| 0 4px;"> | ||
| View chat | ||
| </a> | ||
| =20 | ||
| </div> | ||
| <div style=3D"border-top: 1px solid #e2e8f0; color: #475569; font-siz= | ||
| e: 12px; margin-top: 64px; padding-top: 24px; line-height: 1.6;"> | ||
| <p>© 2024 Coder. All rights reserved - <a = | ||
| href=3D"http://test.com" style=3D"color: #2563eb; text-decoration: none;">h= | ||
| ttp://test.com</a></p> | ||
| <p><a href=3D"http://test.com/settings/notifications" style=3D"colo= | ||
| r: #2563eb; text-decoration: none;">Click here to manage your notification = | ||
| settings</a></p> | ||
| <p><a href=3D"http://test.com/settings/notifications?disabled=3Db78= | ||
| 9bd75-d7c6-4cab-9757-1147ab184903" style=3D"color: #2563eb; text-decoration= | ||
| : none;">Stop receiving emails like this</a></p> | ||
| </div> | ||
| </div> | ||
| </body> | ||
| </html> | ||
|
|
||
| --bbe61b741255b6098bb6b3c1f41b885773df633cb18d2a3002b68e4bc9c4-- |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.