feat(site): add search + filter tabs for template builder modules#26674
Open
aqandrew wants to merge 7 commits into
Open
feat(site): add search + filter tabs for template builder modules#26674aqandrew wants to merge 7 commits into
aqandrew wants to merge 7 commits into
Conversation
| @@ -0,0 +1,51 @@ | |||
| import { useMemo } from "react"; | |||
| import uFuzzy from "ufuzzy"; | |||
| }, [allItems, query, searchProperties]); | ||
|
|
||
| return searchedItems; | ||
| } |
Contributor
There was a problem hiding this comment.
probably good to move this hook to the TemplateBuilder/ package since we are the only consumer right now
Contributor
Author
There was a problem hiding this comment.
Since the hook is based on IconsPage,
I was thinking of replacing IconsPage's fuzzy search logic with this hook. But that would require extending the hook to handle highlighting logic with mark elements, so that should probably be a separate PR
Contributor
There was a problem hiding this comment.
ah yeah, out of scope for this PR for sure, but that's a great idea!
jeremyruppel
approved these changes
Jun 24, 2026
jeremyruppel
left a comment
Contributor
There was a problem hiding this comment.
nice one! just the nit about relocating the hook but then this is good to ship!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref DEVEX-491
Adds a
useFuzzySearchhook based on the logic in IconsPage.tsx, and Storybook stories forModuleSelectStepto verify filter tab count behavior.c16e0d9 and b6ee218 co-written with Claude Code