chore(site/e2e): re-enable externalAuth suite#26648
Draft
jakehwll wants to merge 1 commit into
Draft
Conversation
Drops the test.describe.skip introduced in #17235 now that the listener teardown fix (parent PR) is in place. Whitespace churn in this diff is from biome reformatting the body to its natural indentation after the single-line describe opener.
8762333 to
9b01988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26575. Removes the
test.describe.skipintroduced in #17235 so the externalAuth suite runs in CI again. The teardown fix in the parent PR is what makes this safe; splitting the un-skip into its own commit keeps the bisection signal clean if CI behaviour changes.Large whitespace churn in the diff is biome reformatting the body to its natural indentation after the single-line
test.describe(...)opener. The only semantic change is removing.skip.Heads-up for the reviewer: these tests gate on an Enterprise license (the suite errors out with a banner about multiple external auth providers when run unlicensed). On
test-e2ewithoutCODER_E2E_LICENSE, the suite will fail on the license check, not on the flake. Follow-ups worth considering before merge:continue-on-error: trueso the data we want is collected without blocking PRs.upload-datadogstep so Playwright results show up in Datadog CI Visibility for trend analysis (matching howtest-go-*jobs already report).Refs https://linear.app/codercom/issue/DEVEX-413
Refs coder/internal#356