Skip to content

fix(site): set external auth provider polling status individually (#26313)#26603

Open
github-actions[bot] wants to merge 1 commit into
release/2.34from
backport/26313-to-2.34
Open

fix(site): set external auth provider polling status individually (#26313)#26603
github-actions[bot] wants to merge 1 commit into
release/2.34from
backport/26313-to-2.34

Conversation

@github-actions

Copy link
Copy Markdown

Cherry-pick of #26313

Original PR: #26313 — fix(site): set external auth provider polling status individually
Merge commit: 61fa2ab
Requested by: @matifali

…6313)

fixes #22420
ref DEVEX-369
ref DEVEX-269

The bug on `CreateWorkspacePage`, where clicking one external auth
provider login button disabled all providers' login buttons, was caused
by providers all sharing a single polling status (`"idle" | "polling" |
"abandoned"`) in the `useExternalAuth` hook.

## changes

- Instead of setting one status across all providers, the polling status
in `useExternalAuth` is now tracked for each provider in a record whose
keys are the providers' IDs.
- The biggest diff is a new Storybook file
CreateWorkspacePage.stories.tsx which reproduces the bug behavior from
the issue.
- Until now we've only had CreateWorkspacePageView.stories.tsx, which
isn't able to model the user interactions / API responses needed to
verify the bugfix. This file is unchanged.
- Also deletes `CreateWorkspacePage`'s `useExternalAuth` hook in favor
of the global `useExternalAuth` hook (see #26310)

(co-written with Coder Agents)

(cherry picked from commit 61fa2ab)
@github-actions github-actions Bot added the cherry-pick/v2.34 Cherry-pick PR targeting release/2.34 label Jun 23, 2026
@github-actions github-actions Bot requested a review from matifali June 23, 2026 06:48
@matifali matifali requested review from aqandrew and f0ssel June 23, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/v2.34 Cherry-pick PR targeting release/2.34

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants