fix(coderd/x/nats): default ClusterPort so cluster routes form#26591
Open
cstyan wants to merge 1 commit into
Open
fix(coderd/x/nats): default ClusterPort so cluster routes form#26591cstyan wants to merge 1 commit into
cstyan wants to merge 1 commit into
Conversation
New left Options.ClusterPort at zero when callers (the cli path) didn't set it. parsePeerAddresses overwrites each peer's parsed port with defaultClusterPort (6222), but only when opts.ClusterPort already equals defaultClusterPort; with the zero value that branch is skipped, so replicas dialed peers on the relay URL's HTTP port (8080) instead of 6222 and no cluster routes ever formed. Default ClusterPort in New so the listener and the peer-port rewrite agree. Adds regression tests. Co-authored-by: Mux <mux@coder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original NATS Pubusub PRs wrote
Newbut leftOptions.ClusterPortat the zero value when callers (the cli path) didn't set it.parsePeerAddressesonly rewrites peer routes to the NATS port when ClusterPort equals the default, so replicas dialed peers on the relay URL's HTTP port (8080) instead of 6222 and no cluster routes ever formed. Default ClusterPort in New so the listener and route rewrite agree. Adds regression tests.