feat(site): add home/refresh toolbar to all embedded task app iframes#26535
Closed
bpmct wants to merge 2 commits into
Closed
feat(site): add home/refresh toolbar to all embedded task app iframes#26535bpmct wants to merge 2 commits into
bpmct wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded app iframes in agent chats can get stuck in redirect loops or frozen states with no escape — but the Home/Open toolbar was only rendered when
app.slug === "preview". Task templates frequently use other slugs (e.g.codercom-preview), so those apps had no toolbar at all.Changes
app.slug === "preview"gate — toolbar now renders for all embedded appsRefreshCwIcon) between Home and the dropdown; reloadscontentWindow.locationwithout resetting to the original URLlink.href(the original app URL, not the current iframe location) — intentional for escape-from-redirect-loop recoveryBefore / After
Before — task app with slug
codercom-preview: no toolbar, no way outAfter — same app with
app.slug === "preview"guard removed, toolbar visible with Home + Refresh🤖 Generated with Coder Agents on behalf of @bpmct