chore(coderd/x/chatd): improve runner logging#26522
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
3f0832b to
5601ea1
Compare
hugodutka
commented
Jun 18, 2026
| return errors.Join(errTaskExpectedExit, xerrors.Errorf("generation action: %w", actionErr), ctx.Err()) | ||
| } | ||
| if errors.Is(actionErr, errTaskExpectedExit) || errors.Is(actionErr, chatloop.ErrInterrupted) { | ||
| return nil |
Contributor
Author
There was a problem hiding this comment.
Swallowing these errors here conflates responsibilities. It's the job of runTaskWithRetry to handle errTaskExpectedExit.
| input chatWorkerTaskStartInput, | ||
| locked database.Chat, | ||
| ) error { | ||
| if s.server == nil { |
Contributor
Author
There was a problem hiding this comment.
this can never happen in practice. this guard was redundant
5601ea1 to
264deb2
Compare
2bd76cd to
6a1723a
Compare
0e0d4f2 to
9393f2d
Compare
6a1723a to
ee60ee3
Compare
johnstcn
approved these changes
Jun 18, 2026
9393f2d to
3a3fe52
Compare
3a3fe52 to
21998b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #26412.
errTaskExpectedExitand any other error is joined with a descriptive reason. This will enablerunChatWithRetryto log a descriptive message when a task exits.runTaskWithRetryso logs can be more descriptive.