fix(enterprise/coderd): allow deleting external-agent workspaces#26501
Open
ethanndickson wants to merge 1 commit into
Open
fix(enterprise/coderd): allow deleting external-agent workspaces#26501ethanndickson wants to merge 1 commit into
ethanndickson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled on this while manually testing another workspace change: if a license expires after an external-agent workspace exists, deleting that workspace is rejected because
CheckBuildUsageenforces the external-agent entitlement for every workspace transition. I assume this is unintentional from a product POV.This PR narrows the external-agent entitlement check to start builds. Creating or rebuilding external-agent workspaces still requires the feature entitlement, but stop and delete transitions stay available as cleanup paths.
That matches the managed-agent entitlement precedent (i.e. the usage billing check) in the same
CheckBuildUsagepath, where license enforcement is scoped to start transitions instead of trapping users with resources they can no longer remove.