chore(site): swap AI add-on table icons (em-dash + plain check)#26467
chore(site): swap AI add-on table icons (em-dash + plain check)#26467tracyjohnsonux wants to merge 4 commits into
Conversation
Replace the X (XIcon) used when a user is not consuming an AI seat with a muted em-dash (rendered via — to avoid the U+2014 lint rule) and replace the CircleCheckIcon used when consuming a seat with the simpler lucide CheckIcon. Applies to the Users and Organization Members admin tables, both of which share the AISeatCell component. Generated with Coder Agents on behalf of @tracyjohnsonux.
|
/coder-agents-review |
|
Chat: Review posted | View chat Review history
deep-review v0.7.1 | Round 1 | Last posted: Round 1, no findings, COMMENT. Review Finding inventoryFindings
No findings. Round logRound 1Panel (Bisky, Hisoka, Mafu-san, Mafuuu, Pariston, Nami, Ging-ts, Ging-react, Gon, Leorio, Chopper). 0 findings. Reviewed against 787392e..c17269b. About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
There was a problem hiding this comment.
Clean, proportional change. Single-file icon swap in a shared component with existing story coverage for both branches. The em-dash entity approach correctly avoids the UTF-8 lint rule while achieving the intended UI, and the added role="img" + aria-label on the text span preserves accessibility.
0 P0-P2. 0 P3-P4. 0 Nit.
Process note (commit message): The commit body describes the mechanical swap ("Replace XIcon with em-dash, replace CircleCheckIcon with CheckIcon") but doesn't explain why these replacements are better. An X icon reads as rejection rather than absence; a muted em-dash better signals "not applicable." A circled check is visually heavy; a plain check is lighter. That reasoning would help a future git log reader. (Leorio)
"Pulled every thread. Boring code gets silence." (Hisoka)
🤖 This review was automatically generated with Coder Agents.
Updates the icons in the AI add-on column for the admin tables on
/deployment/usersand/organizations/.../members.XIcon→ muted em-dash (text-content-disabled).CircleCheckIcon→ plainCheckIconfromlucide-react(no circle, stilltext-content-success).Both tables share
site/src/modules/users/AISeatCell.tsx, so the single-file change coversUsersTable.tsxandOrganizationMembersTable.tsx.Screenshot
Users admin table on a local dogfood build of this branch (
/deployment/users):Notes
—rather than a literalU+2014character, so it does not tripmake lint/emdash(seeAGENTS.md/scripts/check_emdash.sh). The browser still renders an em-dash.aria-labels (Consuming AI seat/Not consuming AI seat) and addedrole="img"on the em-dash span so screen readers still announce the state.UsersTable.tsxandOrganizationMembersTable.tsxuseAISeatCell(verified via search).