test(cli): increase timeouts to fix Golden test flakes under CI load#26464
Draft
DanielleMaywood wants to merge 1 commit into
Draft
test(cli): increase timeouts to fix Golden test flakes under CI load#26464DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 This PR was written by Coder Agent on behalf of Danielle Maywood
The
genCI job runsTZ=UTC go test ./cli -run="Test(CommandHelp|ServerYAML|ErrorExamples|.*Golden)" -update, which executes all matching tests in a singlego testinvocation with full parallelism. Several subtests spin up their own coderd with provisioner daemons (setupCLITaskTestwithIncludeProvisionerDaemon: true,prepareTestDatawithIncludeProvisionerDaemon: true). Under CI load, the 25-secondtestutil.WaitLongtimeout is insufficient for provisioning operations to complete, causingcontext deadline exceedederrors acrossTest_TaskLogs_Golden,TestCommandHelp, and other golden tests.Increase all setup and command execution timeouts from
testutil.WaitLong(25s) totestutil.WaitSuperLong(60s) in the task test files andprepareTestData. This follows the precedent set by #21725, which fixed a similar timeout flake inTestGitSSH.Closes coder/internal#1561