Skip to content

fix(coderd): strip injected context from chat watch events#26397

Merged
ethanndickson merged 3 commits into
mainfrom
chatd-pubsub-j89v
Jun 16, 2026
Merged

fix(coderd): strip injected context from chat watch events#26397
ethanndickson merged 3 commits into
mainfrom
chatd-pubsub-j89v

Conversation

@ethanndickson

Copy link
Copy Markdown
Member

Chat watch events publish through Postgres NOTIFY, so embedding the full REST chat payload can exceed the payload limit when last_injected_context grows. Strip LastInjectedContext from watch payloads, matching the existing Files omission, while keeping DiffStatus populated for diff_status_change events and leaving GET /chats/{id} unchanged.

A previous attempt in #26368 introduced a separate summary type for watch events. This avoids making that API change prematurely: one large optional field is not enough reason to split the shared Chat shape by endpoint, so this keeps the existing type and omits the heavy detail field from pubsub payloads.

Closes CODAGT-501

@linear-code

linear-code Bot commented Jun 16, 2026

Copy link
Copy Markdown

CODAGT-501

@ethanndickson ethanndickson marked this pull request as ready for review June 16, 2026 07:09

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f49219abd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/exp_chats_test.go Outdated
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: e74013ecd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson ethanndickson requested a review from johnstcn June 16, 2026 08:16
@johnstcn johnstcn requested a review from hugodutka June 16, 2026 08:20

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanndickson ethanndickson merged commit e345e06 into main Jun 16, 2026
28 checks passed
@ethanndickson ethanndickson deleted the chatd-pubsub-j89v branch June 16, 2026 12:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants