test: isolate passive chatd internal tests#26369
Open
ethanndickson wants to merge 2 commits into
Open
Conversation
218db58 to
52ecd86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
newInternalTestServeruse option functions for logger, clock, and worker startup, and make it passive by default so internal chatd tests only opt into background execution when they need a real worker.Use the passive server path in
TestAwaitSubagentCompletionfor the state-driven subtests, keepContextCanceledexplicitly active for real provider cancellation coverage, and keep the fail-fast default AI provider base URL so accidental provider calls still fail immediately.Closes CODAGT-586