test(enterprise/coderd): stabilize TestUserSkillAuditDiffTracksContent#26326
Draft
ethanndickson wants to merge 1 commit into
Draft
test(enterprise/coderd): stabilize TestUserSkillAuditDiffTracksContent#26326ethanndickson wants to merge 1 commit into
ethanndickson wants to merge 1 commit into
Conversation
GetAuditLogsOffset orders by "time" DESC with no tiebreaker, and dbtime.Now rounds to microseconds, so two audit logs emitted in quick succession can land in the same microsecond and return in non-deterministic order. Sort the rows by Action descending before indexing so positional access is stable regardless of timestamp collisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAuditLogsOffsetorders by"time" DESCwith no tiebreaker, anddbtime.Nowrounds to microseconds, so two audit logs emitted in quick succession (especially on platforms with coarser clock resolution like Windows) can land in the same microsecond and Postgres is free to return them in either order. The test then assumes positional ordering and breaks.Sort
rowsbyActiondescending before indexing sorows[0]is the update log androws[1]is the create log regardless of timestamp collisions.Closes CODAGT-585
Closes coder/internal#1551