Skip to content

chore: refactor mock websocket to make open explicit#26323

Open
code-asher wants to merge 1 commit into
mainfrom
asher/refactor-mock-websocket
Open

chore: refactor mock websocket to make open explicit#26323
code-asher wants to merge 1 commit into
mainfrom
asher/refactor-mock-websocket

Conversation

@code-asher

@code-asher code-asher commented Jun 11, 2026

Copy link
Copy Markdown
Member

Callers can now choose when to open and emit the initial message. This will enable finer testing for some incoming bug fixes related to the timing of dynamic parameter sockets and requests.

I opted to add a callback to preserve the current behavior for existing tests and make the transition easier, but the way I imagine it is that future tests can omit the callback and emit the events under whatever condition they need.

The only behavorial change are:

  • the web socket error test, which now emits a close error without first opening (I think this was the original intent, to test a connection that failed to even open)
  • I added some missing diagnostics to some responses (just to be thorough)
  • I changed one of the IDs to match in two tests

Figured I could break this out rather than try refactoring it together with the flake fixes.

@code-asher code-asher force-pushed the asher/refactor-mock-websocket branch from f0ddcfa to 44065e1 Compare June 11, 2026 23:52
Callers can now choose when to open and emit the initial message.  This
will enable finer testing for some incoming bug fixes related to the
timing of dynamic parameter sockets and requests.
@code-asher code-asher force-pushed the asher/refactor-mock-websocket branch from 44065e1 to 9ffd0e9 Compare June 11, 2026 23:56
@code-asher code-asher requested a review from jeremyruppel June 12, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant