chore: refactor mock websocket to make open explicit#26323
Open
code-asher wants to merge 1 commit into
Open
Conversation
f0ddcfa to
44065e1
Compare
Callers can now choose when to open and emit the initial message. This will enable finer testing for some incoming bug fixes related to the timing of dynamic parameter sockets and requests.
44065e1 to
9ffd0e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers can now choose when to open and emit the initial message. This will enable finer testing for some incoming bug fixes related to the timing of dynamic parameter sockets and requests.
I opted to add a callback to preserve the current behavior for existing tests and make the transition easier, but the way I imagine it is that future tests can omit the callback and emit the events under whatever condition they need.
The only behavorial change are:
diagnosticsto some responses (just to be thorough)Figured I could break this out rather than try refactoring it together with the flake fixes.