Skip to content

fix(offlinedocs): use portable -r flag in copyImages.sh#26221

Open
nickvigilante wants to merge 1 commit into
mainfrom
fix/offlinedocs-copyimages-macos
Open

fix(offlinedocs): use portable -r flag in copyImages.sh#26221
nickvigilante wants to merge 1 commit into
mainfrom
fix/offlinedocs-copyimages-macos

Conversation

@nickvigilante

Copy link
Copy Markdown
Contributor

Summary

cp --recursive is GNU-specific and not recognized by BSD cp on macOS. BSD cp treats --recursive as a third path argument, producing cp: --recursive: Not a directory.

This replaces --recursive (placed after operands) with the POSIX-portable -r flag placed before operands, which works on both Linux and macOS.


Generated by Coder Agents on behalf of @nickvigilante

@nickvigilante

Copy link
Copy Markdown
Contributor Author

CI status

All three failures are unrelated to this change:

Check Reason
assign-author Bot workflow that auto-assigns the PR author; requires the author's personal GitHub token, not available here. Not fixable from this PR.
test-go-race-pg Race condition in TestPrebuildsAutobuild/AutostopScheduleOnlyTriggersAfterClaim (enterprise/coderd prebuilds code). This test was already failing on main in CI run 27284635883 before this PR was opened, confirming it's a pre-existing intermittent flake.
required Downstream gate that fails because test-go-race-pg failed.

This PR changes exactly one line in offlinedocs/scripts/copyImages.sh and has no Go code changes. Ready for human review.


Generated by Coder Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant