feat: add right panel tabs for workspace apps and ports#26208
Draft
ethanndickson wants to merge 3 commits into
Draft
feat: add right panel tabs for workspace apps and ports#26208ethanndickson wants to merge 3 commits into
ethanndickson wants to merge 3 commits into
Conversation
Docs preview📖 View docs preview for |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6e6d829 to
0476e85
Compare
be8f4c3 to
350cef5
Compare
0476e85 to
393908a
Compare
350cef5 to
5f8c3b8
Compare
393908a to
aa8b5f2
Compare
4c7360a to
eb4f9a3
Compare
0db6498 to
51b7fad
Compare
51b7fad to
0887837
Compare
eb4f9a3 to
ef0f871
Compare
Extend the Coder Agents right-panel add-tab control so users can open embeddable workspace apps and forwarded ports as right-panel tabs alongside terminals. The add-tab dropdown now lists the agent's visible workspace apps and a Ports submenu. Command apps (e.g. Claude Code) open as a renamed terminal tab running the app's command; embeddable subdomain apps open in a WorkspaceAppFrame tab; non-embeddable apps fall back to the normal app launcher. Selecting a listening or shared port opens a PortPreviewPanel tab built from the port-forward URL. The Ports submenu reuses the existing WorkspacePillPorts data hook and menu items, extended with an optional create-tab callback, instead of duplicating the port-forwarding query and rendering logic. Add the workspace_app and port variants to the right-panel tab model with hydration validation that drops app tabs whose app no longer exists and port tabs when wildcard access is unavailable, and document the feature.
ef0f871 to
24eae83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #26088 to add right-panel tabs in AgentsPage for workspace apps and forwarded ports, so users can keep app previews and port views alongside terminals while working in the chat view. Adds the add-tab control, the port preview panel, and persisted per-agent tab state for apps and ports. Extracts a shared
usePortsDatahook so the add-tab control, workspace pill, and the existingPortForwardButtonread listening and shared ports from one place. Also fixes the tab list dropping persisted port tabs when the wildcard hostname is briefly empty, and restricts app tabs to embeddable apps.Depends on #26088