fix(aibridge): initiate SSE stream before agentic continuation to avoid IsStreaming race#26139
Open
ssncferreira wants to merge 1 commit into
Open
fix(aibridge): initiate SSE stream before agentic continuation to avoid IsStreaming race#26139ssncferreira wants to merge 1 commit into
ssncferreira wants to merge 1 commit into
Conversation
…id IsStreaming race
89e2a12 to
9c691b7
Compare
dannykopping
reviewed
Jun 8, 2026
Contributor
dannykopping
left a comment
There was a problem hiding this comment.
Nice fix! Are you able to add a test which exposes this issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agentic loop has a race between the main goroutine and the
Startgoroutine on the sharedResponseWriter. When an iteration's response contains only injected-tool events (no text to relay),Startmay not have calledInitiateStreamby the time main reaches theIsStreamingcheck on the next iteration. TheIsStreamingcheck then returns false, main writes a JSON error viawriteUpstreamError, andStartlater writes SSE headers and events on top, producing a malformed JSON+SSE response:Fix: explicitly call
events.InitiateStream(w)at the agentic continuation point so the SSE stream is committed before the next iteration runs. Keepsmessagesconsistent with the pattern already used inchatcompletions/streaming.go.sync.Oncemakes the double call safe.Related: coder/internal#1524
Related: #25654
Closes: https://linear.app/codercom/issue/AIGOV-336/flake-teststreaminginterception-agenticloopfailoveragentic-all-keys
Note
Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira