Skip to content

refactor(aibridge): apply key pool failover follow-ups#26130

Merged
ssncferreira merged 1 commit into
mainfrom
ssncf/keypool-failover-followups
Jun 19, 2026
Merged

refactor(aibridge): apply key pool failover follow-ups#26130
ssncferreira merged 1 commit into
mainfrom
ssncf/keypool-failover-followups

Conversation

@ssncferreira

@ssncferreira ssncferreira commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Applies follow-ups from the key pool failover work:

  • Add a test verifying key pool state is shared across bridged and passthrough routes.
  • Refactor the key failover and passthrough tests to use the shared MockUpstream helper.
  • Simplify how the request body option is passed through the Anthropic messages interceptor.
  • Make ResponseErrorFromKeyPool nil-safe and cover it with a test.

Closes: https://linear.app/codercom/issue/AIGOV-398/small-follow-up-cleanups-for-key-failover

Note

Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira

@ssncferreira Graphite App

ssncferreira commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 8, 2026
Merged
Merged
Merged
Merged
@linear-code

linear-code Bot commented Jun 8, 2026

Copy link
Copy Markdown

AIGOV-398

@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from 08da7c1 to cae2a4d Compare June 8, 2026 09:25
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from b6140db to 168089f Compare June 8, 2026 09:25
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from cae2a4d to be5423c Compare June 8, 2026 12:17
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch 2 times, most recently from 46278da to b7192ab Compare June 8, 2026 12:19
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from be5423c to 487e465 Compare June 8, 2026 12:19
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from b7192ab to 0d71a03 Compare June 8, 2026 19:45
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from 487e465 to 186b1fb Compare June 8, 2026 19:45
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from 0d71a03 to e6514e3 Compare June 8, 2026 19:45
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch 2 times, most recently from c350d1f to abe8adb Compare June 9, 2026 08:36
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from e6514e3 to 8ba34a4 Compare June 9, 2026 08:36
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from abe8adb to 698786c Compare June 9, 2026 08:43
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch 2 times, most recently from 00717e0 to deed2d6 Compare June 9, 2026 09:02
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from 698786c to 3ba6ed4 Compare June 9, 2026 09:02
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch 2 times, most recently from 1700fb8 to a2d05a1 Compare June 9, 2026 09:50
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch 2 times, most recently from 335d56b to afd8e0d Compare June 9, 2026 11:38
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from a2d05a1 to 1c75f82 Compare June 9, 2026 11:38
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from afd8e0d to f83b92a Compare June 9, 2026 12:30
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from 1c75f82 to d823720 Compare June 9, 2026 12:30
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from f83b92a to 21018d9 Compare June 9, 2026 13:00
@ssncferreira ssncferreira marked this pull request as ready for review June 9, 2026 13:15
@ssncferreira ssncferreira requested a review from pawbana June 9, 2026 13:15
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch from d823720 to a4d0340 Compare June 17, 2026 08:46
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch 4 times, most recently from f86399e to bca37ca Compare June 18, 2026 11:21
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch 2 times, most recently from 64c639a to af3f556 Compare June 18, 2026 16:28
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from bca37ca to 4283eec Compare June 18, 2026 16:28
@datadog-coder

This comment has been minimized.

Sign in to view
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from 4283eec to b1741b7 Compare June 18, 2026 16:37
@ssncferreira ssncferreira force-pushed the ssncf/separate-provider-interceptor-configs branch 2 times, most recently from bf30545 to a22dd57 Compare June 18, 2026 16:48
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from b1741b7 to 466088c Compare June 18, 2026 16:48
@ssncferreira Graphite App

ssncferreira commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 19, 7:47 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 19, 7:49 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 19, 8:01 AM UTC: @ssncferreira merged this pull request with Graphite.

@ssncferreira ssncferreira changed the base branch from ssncf/separate-provider-interceptor-configs to graphite-base/26130 June 19, 2026 07:48
@ssncferreira ssncferreira changed the base branch from graphite-base/26130 to main June 19, 2026 07:48
@ssncferreira ssncferreira force-pushed the ssncf/keypool-failover-followups branch from 466088c to f75ceee Compare June 19, 2026 07:48
@ssncferreira ssncferreira merged commit fec21e1 into main Jun 19, 2026
30 checks passed
@ssncferreira ssncferreira deleted the ssncf/keypool-failover-followups branch June 19, 2026 08:01
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pawbana pawbana pawbana approved these changes

Assignees

@ssncferreira ssncferreira

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ssncferreira @pawbana