fix(cli): bail early with human-readable error if gpg-agent socket missing#26125
Open
TheRealShek wants to merge 1 commit into
Open
fix(cli): bail early with human-readable error if gpg-agent socket missing#26125TheRealShek wants to merge 1 commit into
TheRealShek wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12681
Problem
coder ssh -Gfails with rawno such file or directorywhen the localgpg-agent isn't running. The error appears deep in the forwarding logic
with no actionable guidance.
Fix
Added early
os.Statcheck on the gpg-agent extra socket in bothcli/ssh_other.go(Linux/macOS) andcli/ssh_windows.gobefore anyforwarding is attempted. If the socket doesn't exist, returns a
human-readable error suggesting
gpg-agent --daemon.Verification
Tests
Added
TestSSH_ForwardGPG_AgentNotRunning. SetsGNUPGHOMEto an emptytemp dir so the socket is guaranteed missing, then calls
forwardGPGAgentdirectly with
nilsshClient — safe because theos.Statcheck exitsbefore the client is touched. No live server needed.
AI Disclosure
AI tools were used to assist with codebase tracing. All code written
and verified manually by me.