Skip to content

review fixes + refactoring for 26035 #26121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnstcn wants to merge 11 commits into from
Closed

review fixes + refactoring for 26035 #26121

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
26a5e7b
chore: simplify canonicalization
johnstcn Jun 5, 2026
17fbf11
refactor: change db2sdk.CanonicalAIProviderType to sdk type and remov…
johnstcn Jun 5, 2026
66c5544
add test coverage for direct provider hints in case of invalid config
johnstcn Jun 5, 2026
5237912
add coverage for enabledProviderContainsName
johnstcn Jun 5, 2026
8ca2ed1
fix: skip unnecessary provider type recanonicalization
johnstcn Jun 5, 2026
4d76f03
fix incorrect log
johnstcn Jun 5, 2026
a3bb9f5
second round of deep-review fixes
johnstcn Jun 5, 2026
97c75d5
chore: address R1 findings
johnstcn Jun 8, 2026
40c0d0b
address R2 P3
johnstcn Jun 8, 2026
06fdfc0
make canonicalized provider its own type
johnstcn Jun 8, 2026
ffedf25
address CRF-10
johnstcn Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix incorrect log
  • Loading branch information
@johnstcn
johnstcn committed Jun 5, 2026
commit 4d76f03cb71c37d9d8c4ef5fcb0c32ef2ebe6c30
2 changes: 1 addition & 1 deletion coderd/ai_providers_migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func SeedAIProvidersFromEnv(
case found:
existingSettings, err := db2sdk.AIProviderSettings(existing.Settings)
if err != nil {
return xerrors.Errorf("decode existing settings for %q: %w", dp.Name, err)
return xerrors.Errorf("decode existing settings for %q: %w", existing.Name, err)
}
// Load existing bearer keys so the canonical hash
// includes credentials for comparison.
Expand Down