fix: forward attached filenames to Anthropic chat models#26051
Open
ethanndickson wants to merge 1 commit into
Open
fix: forward attached filenames to Anthropic chat models#26051ethanndickson wants to merge 1 commit into
ethanndickson wants to merge 1 commit into
Conversation
Previously, fantasy's Anthropic provider adapter accepted PDF and text FileParts but dropped the filename on the floor, so Claude (direct or via Bedrock) saw the document bytes without any handle and could not answer questions like "what's in foo.pdf". Other providers (OpenAI, Gemini, OpenRouter, Vercel) already forwarded filenames. Bumps coder/fantasy past coder/fantasy#38, which sanitizes FilePart.Filename and sets it as the Anthropic DocumentBlockParam.Title for both application/pdf and text/* attachments, and emits a CallWarning for unsupported FilePart media types instead of silently dropping them. On this side, plumbs the resolved filename through partsToMessageParts so the FilePart literal carries it into the provider. The TestModelFromConfig_AnthropicPDFFilePartReachesProvider regression test now asserts the outbound Anthropic request includes the sanitized title ("quarterly_report.v1.pdf" becomes "quarterly report v1 pdf"). Closes CODAGT-545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, fantasy's Anthropic provider adapter accepted PDF and text FileParts but dropped the filename on the floor, so Claude (direct or via Bedrock) saw the document bytes without any handle and could not answer questions like "what's in foo.pdf". Other providers (OpenAI, Gemini, OpenRouter, Vercel) already forwarded filenames.
Bumps
coder/fantasypast coder/fantasy#38, which sanitizesFilePart.Filenameand sets it as the AnthropicDocumentBlockParam.Titlefor bothapplication/pdfandtext/*attachments, and emits aCallWarningfor unsupportedFilePartmedia types instead of silently dropping them.On this side, plumbs the resolved filename through
partsToMessagePartsso theFilePartliteral carries it into the provider. The existingTestModelFromConfig_AnthropicPDFFilePartReachesProviderregression test is extended to assert the outbound Anthropic request includes the sanitized title (quarterly_report.v1.pdfbecomesquarterly report v1 pdf).Closes CODAGT-545