chore: remove Nix dev image from dogfood template and pipeline#26022
Merged
Conversation
The Nix-based dogfood image (codercom/oss-dogfood-nix) is unused. The current mise setup covers the same tooling with far less complexity, so remove the dev image and its build/publish pipeline. - dogfood/coder/main.tf: drop the "Dogfood Nix (Experimental)" image option and its image_tags entry. - .github/workflows/dogfood.yaml: drop the nix matrix entry, the Setup Nix/cache and Build/Push Nix image steps, the flake path triggers, and simplify the now-redundant "!= 'nix'" step guards. - flake.nix: remove the dev_image output and the docker (nix/docker.nix) helper. Keep pnpm2nix, devShells.default, and the package outputs for NixOS users. - Delete nix/docker.nix.
Member
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b979c0faed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Nix dogfood image (
codercom/oss-dogfood-nix) is unused. The current misesetup covers the same tooling with far less complexity, so this removes the dev
image and its build/publish pipeline.
Per Thomas's review, the package outputs and
devShells.defaultstay for NixOSusers in the company; only the dev-image bits are removed.
Changes
dogfood/coder/main.tfDogfood Nix (Experimental)image option and itsimage_tagsentry.github/workflows/dogfood.yamlnixmatrix entry, the Setup Nix / cache-nix-action steps, the Build/Push Nix image steps, and theflake.lock/flake.nixpath triggers. Simplify the now-redundant!= 'nix'step guardsflake.nixdev_imageoutput and thedocker(nix/docker.nix) helpernix/docker.nixNote
pnpm2nixis kept intentionally. It feedsbuildSite→ thepackages.*(coder binary) outputs, not the dev image, so removing it would break
nix buildfor NixOS users.Validation
terraform fmt -check+terraform validatepass fordogfood/coderactionlintpasses on the workflowmake pre-commit-lightpasses (fmt, emdash, typos, shellcheck, actionlint)nixis intentionally absent from the dogfood image, so the flake change wasreviewed by hand;
pnpm2nix,devShells.default, andpackages.*are retainedDecision log
pnpm2nixinput, but it's required by thepackage build we're keeping, so it stays.
nixfrom the matrix makes thematrix.image-version != 'nix'guardsalways-true; simplified them so the workflow doesn't reference a matrix value
that no longer exists (
!= 'nix' && !fork→${{ !fork }}).pipeline already can't run on forks (read-only
GITHUB_TOKEN), so nothing is lost.