refactor(aibridge): clean up keypool and provider error handling#25609
Open
ssncferreira wants to merge 1 commit into
Open
refactor(aibridge): clean up keypool and provider error handling#25609ssncferreira wants to merge 1 commit into
ssncferreira wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dc74869 to
eb01e92
Compare
eb01e92 to
9daef9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up how key pool errors are represented and how they get turned into HTTP responses. Consolidates two error types into a single type with a kind tag, and gives the response helpers in both providers consistent names.
Changes
KeyFailoverConfig.BuildKeyPoolResponseto take the typed key pool error, so each provider can shape the exhaustion response in its own format.MarkKeycallback fromKeyFailoverConfigsince providers can rely on the sharedMarkKeyOnStatushelper.Related to: https://linear.app/codercom/issue/AIGOV-334/aibridge-follow-ups-from-key-failover-prs
Note
Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira